messageTray: Don't play sound when banners are disabled

When support for notification sounds was added, it made some sense
to keep the 'enable-sound' setting independent from 'show-banners'.

However that changed when 'show-banners' was rebranded in the UI as
"Do Not Disturb", as sounds are at least as disturbing as the banners.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2873

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index d89af2b83e7d5f9c871c5c18e20013ce20069686..7aac503ec36488e987bca6f984187a8860bf0cb7 100644 (file)
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -784,8 +784,6 @@ var Source = GObject.registerClass({
 
         if (this.policy.showBanners || notification.urgency == Urgency.CRITICAL)
             this.emit('notification-show', notification);
-        else
-            notification.playSound();
     }
 
     notify(propName) {